Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot replay after undo then rotate #68

Open
Insti opened this issue Jul 17, 2019 · 3 comments
Open

Cannot replay after undo then rotate #68

Insti opened this issue Jul 17, 2019 · 3 comments
Labels

Comments

@Insti
Copy link
Contributor

Insti commented Jul 17, 2019

Play a full game.
Rewind to the start.
Redo the moves - everything works.
Rewind to the start.
Rotate the board.
Redo the moves - Nothing happens.

Expected behavior: The game replays the rotated moves.

@oers
Copy link
Owner

oers commented Jul 18, 2019

To make this work rotate should be implemented in the c code, so that the redo stack can be rotate as well.

@oers oers added the bug label Jul 18, 2019
@Insti
Copy link
Contributor Author

Insti commented Jul 18, 2019

Or the rotate should be implemented entirely in the view so that the c code doesn't need to care about it at all.

@oers
Copy link
Owner

oers commented Jul 20, 2019

The way I implemented undo is:

  • rotate all the moves and lay it as a new game in the engine (c code)
  • the business logic for playing is completely in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants