Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Folia #193

Open
TheShyDolphin opened this issue May 23, 2023 · 2 comments
Open

[Feature Request] Folia #193

TheShyDolphin opened this issue May 23, 2023 · 2 comments
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@TheShyDolphin
Copy link

Consider adding Folia support?

@oddlama oddlama added feature New feature or request help wanted Extra attention is needed labels May 23, 2023
@oddlama
Copy link
Owner

oddlama commented May 23, 2023

I am not opposed to adding support for Folia, but please understand that this is not very high on my list of priorities. Fortunately, a lot of stuff in vane is already modularized to a high extent, so there should only be a handful of things that require changes. That should include everything that handles global state based on events, so:

  • Region management
  • Portal stuff
  • Chest Menus (Also mostly portals / regions)
  • Creeper rebuild.

Nonetheless it will be quite some work to change those without introducing multithreading related bugs. Unfortunately I don't think I will have enough time to do this myself right now. I'm always happy to accept PRs if anyone really needs this and feels confident enough to implement this. If anyone wants to discuss this in detail please visit our Discord :)

@SoundMeister
Copy link

This truely would be awesome to see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants