Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes table do not display all nodes without filters #40

Open
bogdanfazakas opened this issue Oct 2, 2024 · 4 comments
Open

Nodes table do not display all nodes without filters #40

bogdanfazakas opened this issue Oct 2, 2024 · 4 comments
Assignees

Comments

@bogdanfazakas
Copy link
Member

Nodes cannot be displayed after reaching the 10k after lots of scrolling

@tom1145 tom1145 self-assigned this Oct 8, 2024
@mihaisc
Copy link
Contributor

mihaisc commented Oct 14, 2024

@tom1145 status on this?

@bogdanfazakas
Copy link
Member Author

@tom1145 can we find a solution to this on incentive backend so we do not have to update the { “index”: { “max_result_window”: 500000 } } value, updating this might not be enough we can reach these values in a certain amount of time
maybe we can fix it with scroll or smth

@tom1145
Copy link
Collaborator

tom1145 commented Nov 27, 2024

I have this proposal that can help us with this issue.

We can create a function that:

  1. Checks current max_result_window and index total count (already available in /nodes API pagination)
  2. If index count + new nodes to be inserted in count > max_result_window:
    • Calculate new_size = current_count + new nodes to insert count + X% buffer (to be decided)
    • Update via /_settings API in the body

API References:
GET /status/_settings/index.max_result_window (check current limit)

PUT /status/_settings (update limit)
Body:
{
"index": {
"max_result_window": "new_size"
}
}

Let me know if you have any suggestions. Thanks!
@mihaisc @bogdanfazakas

@bogdanfazakas
Copy link
Member Author

I have this proposal that can help us with this issue.

We can create a function that:

  1. Checks current max_result_window and index total count (already available in /nodes API pagination)

  2. If index count + new nodes to be inserted in count > max_result_window:

    • Calculate new_size = current_count + new nodes to insert count + X% buffer (to be decided)
    • Update via /_settings API in the body

API References: GET /status/_settings/index.max_result_window (check current limit)

PUT /status/_settings (update limit) Body: { "index": { "max_result_window": "new_size" } }

Let me know if you have any suggestions. Thanks! @mihaisc @bogdanfazakas

I would not invest time into this atm, if this seems to be the only viable option lets just update it manually until we find a better way.
I'm trying some things atm, and i'll keep you posted if i find another possible solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants