Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oasis networks (mainet and testnet) are mispelled on address.json (1 'p' instead of 2 'pp') #880

Closed
paulo-ocean opened this issue Sep 10, 2024 · 0 comments
Closed

Oasis networks (mainet and testnet) are mispelled on address.json (1 'p' instead of 2 'pp') #880

paulo-ocean opened this issue Sep 10, 2024 · 0 comments
Labels
Type: Bug Something isn't working

Comments

@paulo-ocean
Copy link

paulo-ocean commented Sep 10, 2024 •
edited
Loading

oasis_saphire_testnet should be oasis_sapphire_testnet
oasis_saphire should be oasis_sapphire
This is problematic when we rely on the network name as key to find the configuration from artifacts addresses json file
@paulo-ocean paulo-ocean added the Type: Bug Something isn't working label Sep 10, 2024
@paulo-ocean paulo-ocean changed the title Oasis networks (mainet and testnet) are mispelled on address.json (1 'p' instead od 2 'pp' Oasis networks (mainet and testnet) are mispelled on address.json (1 'p' instead of 2 'pp' Sep 10, 2024
@paulo-ocean paulo-ocean changed the title Oasis networks (mainet and testnet) are mispelled on address.json (1 'p' instead of 2 'pp' Oasis networks (mainet and testnet) are mispelled on address.json (1 'p' instead of 2 'pp') Sep 10, 2024
@paulo-ocean paulo-ocean mentioned this issue Sep 11, 2024
Merged
@giancu4 giancu4 closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulo-ocean @giancu4