Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove functions deprecated in testthat edition 3 #201

Open
chrisholbrook opened this issue Jan 13, 2024 · 2 comments
Open

Remove functions deprecated in testthat edition 3 #201

chrisholbrook opened this issue Jan 13, 2024 · 2 comments

Comments

@chrisholbrook
Copy link
Collaborator

chrisholbrook commented Jan 13, 2024

After upgrading to testthat edition 3, some tests are throwing warnings about deprecated functions. All calls to deprecated functions should be removed, perhaps following this guidance: https://www.tidyverse.org/blog/2022/02/upkeep-testthat-3/

E.g.,

Warning (test-read_glatos_receivers.r:1:1): (code run outside of test_that())
context() was deprecated in the 3rd edition.
Backtrace:

  1. └─testthat::context("Check read_glatos_receivers") at test-read_glatos_receivers.r:1:1
  2. └─testthat:::edition_deprecate(3, "context()")
@chrisholbrook chrisholbrook changed the title Remove testthat functions deprecated in version 3 Remove functions deprecated in testthat edition 3 Jan 13, 2024
@mhpob
Copy link
Contributor

mhpob commented Jan 13, 2024

This is the issue I let you know introduced during our meeting...

FWIW I've been trying to go through and fix via updating to 3e

https://github.com/mhpob/glatos/tree/dev-testthat-3e

Currently about 75% of the way through the current tests (which I how I found #200)

@mhpob
Copy link
Contributor

mhpob commented Feb 16, 2024

Closed by #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants