Тестовете не минават

[mitio]

Тестовете се пускат с bundle exec rake db:test:prepare && bundle exec rspec. В момента не минават ("1358 examples, 33 failures, 1 pending").

Това блокира обновяването към нова версия.

Основната причина да се чупят е добавянето на ново, задължително (NOT NULL) поле address в info_requests и outgoing_messages, което @s2gatev добави.

Аз оправих част от тях в commit, в който ще спомена това issue. Друга част от тях са конфигурационни проблеми - неща, които трябва да се инсталират локално.

Остават:

• rspec ./spec/controllers/request_controller_spec.rb:1957 # RequestController sending overdue request alerts should send alerts for requests where the last event forming the initial request is a followup being sent following a request for clarification
• rspec ./spec/script/handle-mail-replies_spec.rb:15 # When filtering should not fail when not in test mode
• rspec ./spec/script/mailin_spec.rb:24 # When importing mail into the application should not produce any output and should return a 0 code on importing a plain email
• rspec ./spec/models/incoming_message_spec.rb:686 # IncomingMessage when TNEF attachments are attached to messages should flatten all the attachments out
• rspec ./spec/models/incoming_message_spec.rb:172 # IncomingMessage when dealing with incoming mail should ensure cached body text has been parsed correctly
• rspec ./spec/models/incoming_message_spec.rb:179 # IncomingMessage when dealing with incoming mail should correctly convert HTML even when there's a meta tag asserting that it is iso-8859-1 which would normally confuse elinks
• rspec ./spec/models/incoming_message_spec.rb:233 # IncomingMessage when dealing with incoming mail should load an email with funny MIME settings
• rspec ./spec/controllers/api_controller_spec.rb:35 # ApiController when using the API should create a new request from a POST
• rspec ./spec/controllers/api_controller_spec.rb:122 # ApiController when using the API should add a followup to a request
• rspec ./spec/controllers/api_controller_spec.rb:175 # ApiController when using the API should not allow other people's requests to be updated
• rspec ./spec/models/info_request_batch_spec.rb:146 # InfoRequestBatch when sending batches should send requests and notifications for only unsent batch requests
• rspec ./spec/controllers/request_controller_spec.rb:1837 # RequestController when sending a followup message should give an error if the same followup is submitted twice
• rspec ./spec/controllers/request_controller_spec.rb:1812 # RequestController when sending a followup message should send the follow up message if you are the right user
• rspec ./spec/models/info_request_batch_spec.rb:98 # InfoRequestBatch when creating a batch should substitute authority name for the placeholder in each request
• rspec ./spec/models/info_request_batch_spec.rb:118 # InfoRequestBatch when creating a batch should set the sent_at value of the info request batch
• rspec ./spec/models/info_request_batch_spec.rb:109 # InfoRequestBatch when creating a batch should send requests to requestable public bodies, and return a list of unrequestable ones
• rspec ./spec/controllers/request_controller_spec.rb:50 # RequestController when changing things that appear on the request page should purge the downstream cache when a followup is made
• rspec ./spec/integration/create_request_spec.rb:8 # When creating requests should associate the request with the requestor, even if it is approved by an admin
• rspec ./spec/integration/admin_spec.rb:49 # When administering the site allows redelivery of an incoming message to more than one request
• rspec ./spec/integration/admin_spec.rb:28 # When administering the site allows redelivery of an incoming message to a closed request
• rspec ./spec/controllers/request_controller_spec.rb:1065 # RequestController when creating a new request should let you submit another request with the same title
• rspec ./spec/controllers/request_controller_spec.rb:1029 # RequestController when creating a new request should create the request and outgoing message, and send the outgoing message by email, and redirect to request page when input is good and somebody is logged in
• rspec ./spec/controllers/request_controller_spec.rb:1114 # RequestController when creating a new request should ignore the rate limit for specified users
• rspec ./spec/controllers/request_controller_spec.rb:1089 # RequestController when creating a new request should respect the rate limit
• rspec ./spec/controllers/admin_general_controller_spec.rb:10 # AdminGeneralController when viewing front page of admin interface should render the front page
• rspec ./spec/controllers/admin_request_controller_spec.rb:74 # AdminRequestController when administering the holding pen shows a rejection reason for an incoming message from an invalid address
• rspec ./spec/controllers/admin_request_controller_spec.rb:84 # AdminRequestController when administering the holding pen guesses a misdirected request
• rspec ./spec/mailers/request_mailer_spec.rb:61 # RequestMailer when receiving incoming mail should store mail in holding pen and send to admin when the from email is unknown and only authorites can reply
• rspec ./spec/mailers/request_mailer_spec.rb:177 # RequestMailer when receiving incoming mail should destroy the messages sent to a request if marked to do so
• rspec ./spec/mailers/request_mailer_spec.rb:152 # RequestMailer when receiving incoming mail should send all new responses to holding pen if a request is marked to do so
• rspec ./spec/mailers/request_mailer_spec.rb:41 # RequestMailer when receiving incoming mail should store mail in holding pen and send to admin when the from email is empty and only authorites can reply
• rspec ./spec/mailers/request_mailer_spec.rb:81 # RequestMailer when receiving incoming mail should ignore mail sent to known spam addresses
• rspec ./spec/mailers/request_mailer_spec.rb:24 # RequestMailer when receiving incoming mail should store mail in holding pen and send to admin when the email is not to any information request