Skip to content
This repository has been archived by the owner on Dec 22, 2020. It is now read-only.

Improve the documentation #1

Open
mvila opened this issue Nov 6, 2015 · 8 comments
Open

Improve the documentation #1

mvila opened this issue Nov 6, 2015 · 8 comments

Comments

@mvila
Copy link
Member

mvila commented Nov 6, 2015

I am a stupid French who speaks English like a Spanish cow...

So please, if you can, help me improve the documentation (and my English at the same time).

You can edit the README.md file directly from Github at this address.

Cheers! :)

@egeland
Copy link
Contributor

egeland commented Nov 6, 2015

Hi Manu,

While I find your self-description amusing, it's quite obviously not true.
I just read through the README and made a small amount of fixes, see #2

Cheers,
Frode

@mvila
Copy link
Member Author

mvila commented Nov 6, 2015

Hi @egeland,

You are my hero! Thanks a lot. :)

@alonronin
Copy link

looks nice, however i didn't understand how you support database on DocumentStore. where is the actual connection to the DB or am I missing something, and if so, is there any support for MongoDB for example?

@mvila
Copy link
Member Author

mvila commented Dec 13, 2015

@alonronin: The connection to the database is handled by KeyValueStore. I agree that the documentation should be more clear about that.

Concerning MongoDB support, unfortunately, the answer is no because MongoDB doesn't support transactions which kind of contradict the point of my module.

@alonronin
Copy link

@mvila I though that you're abstract the transaction on top of the DB 😄
well, still is pretty nice and clean code. Just use webpack and it's perfect 😉

@mvila
Copy link
Member Author

mvila commented Dec 14, 2015

@alonronin: I use Browserify and I assume it should also work with webpack isn't it?

@alonronin
Copy link

Yep, just trolling...
On Dec 14, 2015 3:07 AM, "Manuel Vila" [email protected] wrote:

@alonronin https://github.com/alonronin: I use Browserify and I assume
it should also work with webpack isn't it?


Reply to this email directly or view it on GitHub
#1 (comment)
.

@mvila
Copy link
Member Author

mvila commented Dec 14, 2015

😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants