Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract the commands and their run to make cargo-scout more testable #79

Open
o0Ignition0o opened this issue Jan 14, 2020 · 0 comments

Comments

@o0Ignition0o
Copy link
Owner

There's a lot of cover_skip in the codebase because commands cannot be easily tested:

    // Skipped from code coverage
    // because an external command
    // cannot be easily unit tested
    #[cfg_attr(tarpaulin, skip)]

We might want to try working on our own command abstraction, that would return a Result<OutputStream, ErrorStream> so we can provide stubs for the tests.

It would allow for more coverage, and we could thus identify and reproduce cornercases easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant