Add option for reading points from text file #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file should list one point coordinate per line, with latitude and longitude separated by whitespace. Signed-off-by: Tormod Volden <[email protected]>
tormodvolden
force-pushed
the
pointsfromfile
branch
from
8f68a63
to
98010d5
Compare
Signed-off-by: Tormod Volden <[email protected]>
|
The second commit is optional. Surely makes sense when reading points from file, whether to update home on any manually added points can be discussed. |
|
I'm not convinced adding that option to main demo is good idea... However we have editable_track and polygon examples, so adding another example based on minimum mapviewer that reads points from file would be acceptable IMO. to make it "perfect" you could try supporting gpx files, just to draw the route recorded on gpx file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how much features you want in the examples, but this turned out useful for me.
Later I might look at periodically reread the file for live updates, and make sure it works for fifos as well.