Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset button? #26

Closed
fdncred opened this issue Jul 19, 2020 · 6 comments
Closed

Reset button? #26

fdncred opened this issue Jul 19, 2020 · 6 comments

Comments

@fdncred
Copy link
Contributor

fdncred commented Jul 19, 2020

I seem to get it into a state where no command is interpreted any longer. I can click the top buttons and they put text in the window but if I hit run or ctrl/cmd-enter nothing happens. There are no errors visible. So, would it be possible to have some type of a reset button? I'm not sure what that would do since when this happens today I have to ctrl-c out and do npm start again.

@jzaefferer
Copy link
Collaborator

There's various errors that aren't handled properly, one category is covered by #12. I have no idea how to recover from those, since the wasm process or worker or whatever it is seems to kinda crash.

For me its enough to reload the page to get back to a working state.

So I think this needs to be addressed by improved error handling.

@sophiajt
Copy link
Contributor

@jzaefferer - if the commands don't work, should we just not show them? I think you were saying you wanted to show them but just have them error when you use them

@jzaefferer
Copy link
Collaborator

Yes, I think "not supported in the browser (via WebAssembly)" is better in this demo than pretending that the command doesn't exist.

@sophiajt
Copy link
Contributor

Maybe we can make the list, like you're doing, and register these commands to return that message. As we start to make them work in wasm, we can remove this shim error registration.

@jzaefferer
Copy link
Collaborator

That sounds good to me!

@jzaefferer
Copy link
Collaborator

I think the WIP notice and eventually dealing with #12 is going to take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants