New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): keep comp name #378

Merged

tipiirai merged 1 commit into nuejs:dev from nobkd:fix/custom-comp-name

Oct 3, 2024

Collaborator

nobkd commented Sep 28, 2024 •

edited

Loading

Follow up to #376, to also render component name to custom attribute with nuejs-core.

My reasoning: #376 (comment)

Still, your decision, if you accept this change, or ignore this PR and undo the last commit from #376


          fix: add custom="<name>" to components

19162d2

nobkd changed the title ~~fix: custom comp name~~ fix(dev): custom comp name

nobkd changed the title ~~fix(dev): custom comp name~~ fix(dev): keep comp name

tipiirai merged commit 5da511c into nuejs:dev

4 checks passed

Contributor

tipiirai commented Oct 3, 2024

Thanks. The reasoning made perfect sense

nobkd deleted the fix/custom-comp-name branch

October 3, 2024 07:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet