Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude tests from npm #354

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Sep 12, 2024

Excludes tests from files to be published to npm.

(commands run from packages sub-dir)

Package sizes in code (with tests):

> du -hcs nuejs glow nuekit nuemark                
140K    nuejs
112K    glow
196K    nuekit
76K     nuemark
524K    total

Sizes of only tests:

> du -hcs nuejs/test glow/test nuekit/test nuemark/test
72K     nuejs/test
64K     glow/test
68K     nuekit/test
28K     nuemark/test
232K    total

232K/524K: About 44% of nue's code size on npm is tests, that gets shipped to every user, but probably isn't used by a single one.

I think it would be fine to just exclude them from npm, but in the end, it's your decision.

@tipiirai tipiirai merged commit de8abed into nuejs:master Sep 12, 2024
4 checks passed
@tipiirai
Copy link
Contributor

This is good. Thanks

@nobkd nobkd deleted the chore/npmignore-tests branch September 12, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants