Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MacOS only section to revert control buttons to default position #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RyanLiu6
Copy link

This is a simple solution to #3, and adds a MacOS specific section using the following:

@supports (-moz-osx-font-smoothing: grayscale) {
  ...

I could be wrong since I only did a bit of research but from inspecting the element using the Browser Toolbox, it seems like the three control buttons (Red Close, Yellow Minimize, and Green Maximize) are not something that Firefox has access to and can control the behaviour and style of.

This seems to be because MacOS is defining these buttons as part of its' Window Management System, rather than something Application based like Windows. Thus, I feel like the best we can do is the put it back where most users expect them, to the top left. I've taken the liberty of making it a bit "spaced", but feel free to edit it to suit what you think fits best for this theme, since you are the author after all!

image

This is what it looks like now!

@nuclearcodecat
Copy link
Owner

do you know if you could make these be centered? there's this solution i guess. also, i think it would be nice if they were on the left by default on mac (assuming you have reversing enabled now), so if you get it working i'll happily add some code that does that, you would have to test it for me later though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants