Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-markdown 7? #24

Open
akx opened this issue Dec 16, 2021 · 1 comment
Open

Upgrade to react-markdown 7? #24

akx opened this issue Dec 16, 2021 · 1 comment

Comments

@akx
Copy link
Member

akx commented Dec 16, 2021

Hey there!

It looks like this package is using a pretty old version of react-markdown and could probably, with some elbow grease, be upgraded to v7. I noticed this via a dependabot warning on [email protected] via @nteract/markdown#react-markdown#remark-parse#trim.

Doing that would also allow using https://github.com/remarkjs/remark-math which seems to, according to some Git history sleuthing – nteract/nteract@61fa1a4, be the evolution of this repo's remark-math stuff. That might help with #5.

I could (try to) do the work, unless there's a good reason not to? :)

@captainsafia
Copy link
Member

@akx Contribution is always welcome! As always, the lag with upgrades sometimes is the time needed to do the upgrade and all the follow ups that come with. Help is definitely appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants