Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon contributions not tied to furnaces #36

Open
nsporillo opened this issue Oct 2, 2019 · 3 comments
Open

Carbon contributions not tied to furnaces #36

nsporillo opened this issue Oct 2, 2019 · 3 comments
Labels
Accepted Good issue, working on a solution enhancement New feature or request help wanted Extra attention is needed

Comments

@nsporillo
Copy link
Owner

Currently the plugin bases carbon contributions from furnaces based on who placed the furnace.

A nice upgrade would support tracking contributions based on who put fuel into a furnace which caused a smelt.

Some edge cases to consider are when multiple players add fuel to furnaces, that information must be persisted through restarts because leftover fuel is allowed to stored in furnaces until the next item to be smelted is inserted.

@nsporillo nsporillo added Accepted Good issue, working on a solution enhancement New feature or request labels Oct 2, 2019
@honsq90
Copy link

honsq90 commented Oct 2, 2019

hello! sounds like a cool plugin, don't mind if I try and tackle this? I play Minecraft myself so this'll be interesting

@nsporillo
Copy link
Owner Author

You’re more then welcome to give it a try, feel free to reach out to me in Discord to discuss anything. This is a pretty substantial change that will likely involve another database table and a lot of new logic that needs testing but the end result will be amazing!

@honsq90
Copy link

honsq90 commented Oct 2, 2019

alrighty, looking to block out some time this weekend :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Good issue, working on a solution enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants