Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that git pull can reliably retrieve all settings files #227

Open
5 tasks
fureigh opened this issue Apr 20, 2018 · 0 comments
Open
5 tasks

Ensure that git pull can reliably retrieve all settings files #227

fureigh opened this issue Apr 20, 2018 · 0 comments
Assignees

Comments

@fureigh
Copy link
Contributor

fureigh commented Apr 20, 2018

User story

As a developer, I want git pull to reliably retrieve all settings files, even ones that Drupal's install script normally write-protects, so that git will work as expected. (In other words, so that I can feel confident that I have the latest versions of the settings files.)

Steps to test

  • Pull down the latest version of master.
  • Run git status and verify that you don't already have any modified settings files. (If you do, please stash them for now or commit changes separately.)
  • Run docker-compose build and docker-compose up. This will ensure that the Drupal install script has run.
  • Check out a remote git branch (TK) that includes a change to a *settings*.php file.
  • Run git status, and confirm that the updated settings file isn't listed as modified.

Technical notes

  • This especially concerns /web/sites/default/*.
  • Git itself doesn't store permissions, so there's no risk of/in pushing write-unprotected files to the repository.
  • Let's check whether to also include a hook re: cf push or the equivalent, though, to guard against accidentally deploying those files in a write-unprotected state. (The current setup only deploys from master, so this should only be relevant to test deployments during development.)

Follow-up on #223.

@mtboesch mtboesch self-assigned this Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants