Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand NSF theme settings to include our custom footer menus #216

Open
3 tasks
fureigh opened this issue Apr 6, 2018 · 1 comment
Open
3 tasks

Expand NSF theme settings to include our custom footer menus #216

fureigh opened this issue Apr 6, 2018 · 1 comment
Assignees
Labels
CivicActions post-launch Post launch (after 03/31/18)

Comments

@fureigh
Copy link
Contributor

fureigh commented Apr 6, 2018

User story

As a site administrator, I want the UI to reflect the state of the code so that I don't have to take nonobvious paths to modify things.

Motivation

The USWDS theme includes a 'Bypass USWDS menu processing for these menus' option, with checkboxes for each standard menu. Those checkboxes don't yet include the two custom menus (footer-national-science-fou and footer-research-gov) we're using in the footer region.

Acceptance criteria

  • When a site developer/administrator goes to /admin/appearance/settings/nsf, they see checkboxes for Footer: National Science Foundation and Footer: Research.gov after the checkbox for Footer menu.
  • After that user clicks one of those checkboxes and then clicks the Save configuration button, the footer menus continue to display.
  • After that user clicks one of those checkboxes and then clicks the Save configuration button and clears the cache, the footer menus' markup no longer includes USWDS alterations (usa-*, etc.).

Technical notes

Implementing this will require the use of nsf/theme-settings.php (copied from the USWDS theme and modified to override) and the Form API, specifically hook_form_system_theme_settings_alter().

@fureigh fureigh added the post-launch Post launch (after 03/31/18) label Apr 6, 2018
@fureigh
Copy link
Contributor Author

fureigh commented Apr 9, 2018

Also use hook_theme_suggestions_block_alter() (a la uswds_theme_suggestions_block_alter() in /uswds/includes/menu.inc)).

@mtboesch mtboesch self-assigned this Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CivicActions post-launch Post launch (after 03/31/18)
Projects
None yet
Development

No branches or pull requests

2 participants