Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 19 LTS #29028

Closed
nakash2050 opened this issue Nov 21, 2024 · 5 comments · Fixed by #28847
Closed

Support for Angular 19 LTS #29028

nakash2050 opened this issue Nov 21, 2024 · 5 comments · Fixed by #28847
Assignees
Labels
scope: angular Issues related to Angular support in Nx type: feature

Comments

@nakash2050
Copy link

Discussed in #29013

Originally posted by MGREMY November 20, 2024
I could be great to have support for the new angular version
image

@kbrilla
Copy link

kbrilla commented Nov 21, 2024

Already in progress: #28847

@leosvelperez leosvelperez closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@leosvelperez leosvelperez reopened this Nov 22, 2024
@leosvelperez leosvelperez self-assigned this Nov 22, 2024
@leosvelperez leosvelperez added type: feature scope: angular Issues related to Angular support in Nx labels Nov 22, 2024
@colinscz
Copy link

@leosvelperez quick question regarding your PR
Will migrations to the new syntax also be included or will you provide some NX generators/commands/schematics which are optional so people could migrate their code.

The migration schematics/commands I am referring to are those:

  • ng g @angular/core:control-flow (For the new template syntax control flow)
  • ng update @angular/cli --name use-application-builder (If I recall there is already an nx migration build executor present, I guess it's this one here: https://nx.dev/nx-api/angular/executors/browser-esbuild)
  • ng g @angular/core:inject-migration

@leosvelperez
Copy link
Member

hey @colinscz!

The @angular/core:control-flow and @angular/core:inject-migration can be run with Nx like any other schematics (nx g ...). If you find issues running them on an Nx workspace, please file a separate issue so we can review it and see if the Angular team can make it more generic or if it requires us to provide a similar generator to compensate.

We provide the @nx/angular:convert-to-application-executor generator to do the same operations as the use-application-builder optional migration from the Angular CLI does.

@colinscz
Copy link

hey @leosvelperez
Thank you for the explanation. In the end I found the right command to execute the control-flow migration.
npx nx generate @angular/core:control-flow-migration

If I run into any issue with the migration I'll file a new one separate from this. :)

@tejasv-tagline
Copy link

Isn't angular 19 support available yet? Many users are waiting for that, can someone please look at the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: angular Issues related to Angular support in Nx type: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants