Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-block deduplication in constant folding has correctness bugs. #6588

Open
TomAFrench opened this issue Nov 21, 2024 · 0 comments
Open
Assignees

Comments

@TomAFrench
Copy link
Member

One of the components which has been causing issues on Noir syncs has been the changes made in #6499 so it's had to be pulled out of the syncs.
I opened this PR to test adding it in isolation and there's a number of test failures.

Sadly all of these tests rely on foreign calls so it's going to be a bit messy to get a nice reproduction case but we should find it and bring it back into this repo to fix the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants