Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to upgrade Pako to be equivalent to zlib 1.2.11? #152

Closed
Nantris opened this issue Dec 3, 2018 · 5 comments
Closed

Plans to upgrade Pako to be equivalent to zlib 1.2.11? #152

Nantris opened this issue Dec 3, 2018 · 5 comments

Comments

@Nantris
Copy link

Nantris commented Dec 3, 2018

I'm having some issues getting Pako's gzip to work interchangeably with Node's. I doubt this is related to the version difference, but it would be awesome if Pako was equivalent to zlib 1.2.11 so that there would be no question it's an issue on my end.

In any case, thanks for sharing this incredible project!

@puzrin
Copy link
Member

puzrin commented Dec 4, 2018

No timeline. There is #139, require significant time to dive into details. Since related issues already exists, i close this one.

If you don't use multistream compression, the only binary difference will be at 0 (no compression) level.

@puzrin puzrin closed this as completed Dec 4, 2018
@Nantris
Copy link
Author

Nantris commented Dec 4, 2018

Thanks for the info @puzrin.

The issue was not related to the difference in versions for anyone who happens upon this.

@puzrin
Copy link
Member

puzrin commented Dec 4, 2018

This is blocker, and #107 is related.

No more differences for binary results from js, seriously. And since nobody needs level 0 compression at all - nobody worries about.

@brandon-leapyear
Copy link

brandon-leapyear commented Jan 18, 2023

This is an old work account. Please reference @brandonchinn178 for all future communication


FYI zlib < 1.2.12 has a vulnerability (CVE-2018-25032), which a scan just picked up on

@puzrin
Copy link
Member

puzrin commented Jan 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants