chore: show button for crypto map if the iframe cannot be loaded #6
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nimiq-website with
|
| Latest commit: |
60ed367
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6a2b9bd6.nimiq-website.pages.dev |
| Branch Preview URL: | https://onmax-handle-not-loading-ifr.nimiq-website.pages.dev |
onmax
force-pushed
the
onmax/handle-not-loading-iframe
branch
from
74c21bf
to
59c4af5
Compare
Albermonte
reviewed
Oct 10, 2024
| w-full aspect="9/16 lg:initial" rounded-8 lg:h-full max-lg:max-h-80dvh ring="1.5 neutral-200" title="Crypto Map" | ||
| :src="cryptoMapUrl" | ||
| sandbox="allow-scripts allow-same-origin allow-popups" | ||
| frameborder="0" | ||
| /> | ||
| </div> | ||
| </section> | ||
| <section v-else bg-neutral-100 pt-0> | ||
| <NuxtLink to="https://map.nimiq.com" target="_blank" mx-auto w-max nq-arrow nq-pill-lg nq-pill-blue> |
There was a problem hiding this comment.
Would be cool to redirect to the same location, eg: Europe if Europe is selected...
There was a problem hiding this comment.
Nah, thinking about it. Better to let the map get the user's location by IP. There will be not a continent selector in the fallback version, just a button
onmax
force-pushed
the
onmax/handle-not-loading-iframe
branch
from
59c4af5
to
1142d12
Compare
onmax
force-pushed
the
onmax/handle-not-loading-iframe
branch
from
1142d12
to
7361d4d
Compare
onmax
force-pushed
the
onmax/handle-not-loading-iframe
branch
2 times, most recently
from
fdd418a
to
391d892
Compare
onmax
force-pushed
the
onmax/handle-not-loading-iframe
branch
from
391d892
to
60ed367
Compare
|
@sisou @danimoh Do you know of a reliable way to handle iframes blocked by ad-blocking extensions or privacy-focused browsers like Brave? I've tried a few things that didn't work:
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enhance the
CryptoMapContinentSelectorcomponent by adding new functionalities for iframe handling and improving user experience when the iframe is blocked.The user will see