Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testament important package: regression not reported in testament #24172

Closed
mratsim opened this issue Sep 25, 2024 · 1 comment
Closed

Testament important package: regression not reported in testament #24172

mratsim opened this issue Sep 25, 2024 · 1 comment

Comments

@mratsim
Copy link
Collaborator

mratsim commented Sep 25, 2024

I'm investigating mratsim/constantine#469.

On the current devel and version2-0 branch this throws:
CI version2-0: image

local devel:
image

While constantine is NOT in the important packages in version2-0, it is for the current devel, yet the test passes there:
image

And the command is the one I used nimble make_lib

pkg "chronicles", "nim c -o:chr -r chronicles.nim"
pkg "chronos", "nim c -r -d:release tests/testall"
pkg "cligen", "nim c --path:. -r cligen.nim"
pkg "combparser", "nimble test --mm:orc"
pkg "compactdict"
pkg "comprehension", "nimble test", "https://github.com/alehander92/comprehension"
pkg "constantine", "nimble make_lib"
pkg "cowstrings"
pkg "criterion", allowFailure = true # needs testing binary
pkg "datamancer"

Note: there is another regression that I have yet to investigate that results in a compiler crash (see mratsim/constantine#468 (comment) )
image

This also crashes for constantine v0.1.0 which is the latest tagged version so it's not a devel/tag version difference.

@mratsim
Copy link
Collaborator Author

mratsim commented Sep 25, 2024

Found the reason, I was using an unsynced master branch mratsim/constantine#468 (comment)

@mratsim mratsim closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant