Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module deprecation? #88

Closed
atomsnc opened this issue Nov 10, 2024 · 2 comments
Closed

Module deprecation? #88

atomsnc opened this issue Nov 10, 2024 · 2 comments

Comments

@atomsnc
Copy link

atomsnc commented Nov 10, 2024

Nginx team adding dynamic resolution of upstreams

See nginx/nginx@db6870e

@splitice
Copy link
Contributor

I'm not @nicholaschiasson but I do think we will be moving over to the native nginx supported jdomain for all 3 of my projects that use jdomain once the nginx supported implementation is:

a) Verified as stable
b) Available and compatible with openresty

I expect this will be within 3-6mo.

This does not discount the value of this project, this project has filled a necessary feature gap for many years. So necessary in fact that the core platform has adopted a very similar feature (as far as I can tell there is nothing this module can do the core implementation cant).

@nicholaschiasson
Copy link
Owner

If this is effectively the resolve feature moving to the community edition of nginx, then I will certainly be deprecating the module once that feature is stabilized. That will be very exciting I think for everyone.

The timing of this news is somewhat a coincidence too, since I've been prompted once again by work to come and re-review this module. I think it would be best for the future of the community however if this sort of feature was officially supported.

Once that time comes, I'll have to thank @splitice and everyone else who has consistently helped out maintaining this thing and tolerated my long absences. I'll have to apologize for not taking the time to give this module the love and care it deserved. I had wanted to address the open issues and continue adding some nice features. I even had a crazy idea to experiment rewriting it in rust, given the strides made toward supporting rust-based nginx module development. But honestly once things were in a state good enough for what I needed, the personal priorities shifted of course, and there was never the time anymore. So sorry to anybody who felt their issue has been dismissed. I hope this module has been able to help your workload in spite of all of that.

In any case, let's hope that nice feature gets merged into the mainline in a timely fashion 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants