Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generation could be more efficient for simple 'repeated' types #1011

Open
dmondrik opened this issue Oct 9, 2023 · 0 comments
Open

Code generation could be more efficient for simple 'repeated' types #1011

dmondrik opened this issue Oct 9, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dmondrik
Copy link
Contributor

dmondrik commented Oct 9, 2023 •
edited by ni-vsts-admins
Loading

In many cases a vector is declared on the stack and the data is copied unnecessarily. Examples:

  • The input int32 array of values in NiRFmxInstrService::SetAttributeI32Array
  • The output float64 array stateVector in NiDAQmxService::GetAnalogPowerUpStates

In at least some cases like this, we should be able to generate code that efficiently:

  • For input, gets the pointer to the request buffer's data()
  • For output, gets the mutable data and reserves the appropriate size.

AB#2545490
@dmondrik dmondrik mentioned this issue Oct 9, 2023
Merged
@maxxboehme maxxboehme added the enhancement New feature or request label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxxboehme @dmondrik