-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering metrics #557
Comments
Hi @fxposter, This seems like an interesting feature. How would you enable the filters? |
This comment was marked as outdated.
This comment was marked as outdated.
Since the proliferation of metrics is primarily caused by NGINX Plus it seems that the most straightforward way to introduce a filter would be by excluding / including based on the N+ API paths as the basis for metrics groups. Things like zone names are highly configuration dependent and could be relatively simple to disrupt. But I can see how something like that could relate to the regex suggestion. |
This comment was marked as outdated.
This comment was marked as outdated.
Hey @fxposter, sorry it took us so long to come back around on this. We just changed the way these projects are managed and saw this request for enhancement. We think it makes sense to pursue a filter for these metrics if you want to take a look at doing the PR. If not, we marked this for "help wanted" if anyone else would like to pick it up! |
hello, nice to hear that. I'll try to do the PR within next two weeks then. |
Is your feature request related to a problem? Please describe.
What do you think about the ability to not show all metrics. There are cases when exporter has a lot of metrics (for example, there are a lot of upstream servers) and the user doesn't need all of them.
Describe the solution you'd like
I propose having the ability to apply 2 types of filters:
Describe alternatives you've considered
it is usually possible to reject some metrics on scraper side, but it's less efficient and usually "what metrics are exposed" and "what metrics are gathered" are controlled by different parties, so I just propose to add this ability to the project.
I'm happy to do the PR if the idea is accepted.
The text was updated successfully, but these errors were encountered: