Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for GRPCRoute to change processor test #2352

Open
kate-osborn opened this issue Aug 8, 2024 · 0 comments · May be fixed by #2835
Open

Add unit tests for GRPCRoute to change processor test #2352

kate-osborn opened this issue Aug 8, 2024 · 0 comments · May be fixed by #2835
Assignees
@sjberman
Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tech-debt Short-term pain, long-term benefit tests Pull requests that update tests
Milestone
v1.6.0

Comments

@kate-osborn
Copy link
Contributor

The unit tests for change processor are missing test cases for GRPCRoute. These tests are important because the change processor component is the core component of NGF. It processes changes to resources and produces the graph that we build NGINX configuration and status from.

A/C:
@kate-osborn kate-osborn added the tech-debt Short-term pain, long-term benefit label Aug 8, 2024
@mpstefan mpstefan added the tests Pull requests that update tests label Aug 13, 2024
@mpstefan mpstefan added this to the v1.5.0 milestone Aug 13, 2024
@mpstefan mpstefan modified the milestones: v1.5.0, v2.0.0 Oct 7, 2024
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Oct 28, 2024
@sjberman sjberman self-assigned this Nov 26, 2024
@sjberman sjberman linked a pull request Nov 27, 2024 that will close this issue
Open
6 tasks
@sjberman sjberman moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tech-debt Short-term pain, long-term benefit tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: 👀 In Review
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

Add more unit tests for GRPCRoute sjberman/nginx-gateway-fabric
3 participants
@mpstefan @sjberman @kate-osborn