refactor(nextcloud_test,nextcloud): run tests on web #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
…s internal Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
|
I also have a branch using a hybrid test, but that requires spawning a separate docker container for every test case. |
Leptopoda
changed the title
Leptopoda
changed the title
|
Doesn't need to be on any milestone since it only affects tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web tests are still a bit flaky when run together, and I didn't set up the test yet (my bash skills are terrible).
Some initial feedback is appreciated, as I don't expect much to change.
To test it yourself:
dart run dart_frog_cli:dart_frog build(in the nc_test_api package)dart run packages/nextcloud_test_api/build/bin/server.dart(in the nc package)dart testAs mentioned above, vm tests are fine, and all tests pass fine when run individually.