Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring logging root logger #5

Open
yonaszmerla opened this issue Oct 28, 2024 · 0 comments
Open

Configuring logging root logger #5

yonaszmerla opened this issue Oct 28, 2024 · 0 comments

Comments

@yonaszmerla
Copy link

The code configures the root logger by running logging.basicConfig.
This should not happen since it configures the root logger for anyone that imports this library.
The library should only emit logs using logging and rely on the user/importer to configure the root logger as he likes.

Therefore the use of logging.basicConfig should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yonaszmerla