Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve workflow to perform all operations on self-hosted runner #104

Open
hvgazula opened this issue Nov 9, 2023 · 7 comments · May be fixed by #109
Open

improve workflow to perform all operations on self-hosted runner #104

hvgazula opened this issue Nov 9, 2023 · 7 comments · May be fixed by #109
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hvgazula
Copy link
Contributor

hvgazula commented Nov 9, 2023

Partial workflow at https://github.com/hvgazula/trained-models/actions/runs/6806826215 barring pushing the branch and docker image on successful testing.

@hvgazula hvgazula added enhancement New feature or request help wanted Extra attention is needed labels Nov 9, 2023
@hvgazula
Copy link
Contributor Author

datalad push ... in a new job keeps failing. For now, leaving it as a step in the same job that configures git seem to work fine.

@gaiborjosue
Copy link
Contributor

@hvgazula I checked the workflow right now, is it this one? https://github.com/hvgazula/trained-models/actions/runs/6813853293/job/18529675234

@hvgazula
Copy link
Contributor Author

Sure, you can use that by removing the last job and moving the steps into the previous one.

@hvgazula
Copy link
Contributor Author

hvgazula commented Nov 11, 2023

Here's the final workflow (with a test docker file) that works end-to-end on the self-hosted ec2 runner and pushes the docker image, weights, and inference scripts only if the docker and singularity tests run successfully. https://github.com/hvgazula/trained-models/actions/runs/6831844963 (edited to add the link).

@hvgazula
Copy link
Contributor Author

and here's the final branch layout https://github.com/hvgazula/trained-models/tree/issue-7

@gaiborjosue
Copy link
Contributor

gaiborjosue commented Nov 11, 2023

Hello @hvgazula, really nice. Do you think it would be best to separate into multiple jobs? Or do you think it is best to keep everything inside one job (a.k.a "create branch")?

@hvgazula
Copy link
Contributor Author

hvgazula commented Nov 11, 2023

I'd leave it as is. No more refactoring at this point. If at all you are interested in separating into multiple jobs, try fixing this workflow first. This issue partially had a role to play in why I ended up with all the steps in one job sandwiched between start and stop ec2 runner. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants