Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin merge connection strategy #1231

Closed
LionelJouin opened this issue Feb 21, 2022 · 5 comments
Closed

Begin merge connection strategy #1231

LionelJouin opened this issue Feb 21, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@LionelJouin
Copy link
Member

Overview

Together with the new source routing feature, we would like our NSCs to have the ability to re-configure their connections on the fly, so without having to close, and re-request (mostly to update the IP context). But currently, the begin client chain component is preventing this due a merge function supporting only the extracontext for now.

Here is the link to the function, my proposal would be to not merge the ip contexts and only keep the requested one.

References

networkservicemesh/api#119
https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/common/begin/merge.go#L39

@denis-tingaikin
Copy link
Member

Hmm. Can this be related to networkservicemesh/cmd-forwarder-vpp#441?

@denis-tingaikin
Copy link
Member

/cc @edwarnicke

@denis-tingaikin
Copy link
Member

/cc @glazychev-art

@denis-tingaikin denis-tingaikin added the bug Something isn't working label Feb 21, 2022
@LionelJouin
Copy link
Member Author

yes, from what I understood it seems related. So far, the only blocking element is the begin chain component. I tried with the changes in my environment and it worked fine (my NSC re-request with updated source IPs and policies)

LionelJouin added a commit to Nordix/nsm-sdk that referenced this issue Feb 23, 2022
Using the Client chain, the network service client cannot update the
IPContext without the mergeConnectionContext function implemented. A NSC
might want to update it if it needs to add, update or delete routes, src
IP addresses (VIPs...), policies...
LionelJouin added a commit to Nordix/nsm-sdk that referenced this issue Feb 23, 2022
Using the Client chain, the network service client cannot update the
IPContext without the mergeConnectionContext function implemented. A NSC
might want to update it if it needs to add, update or delete routes, src
IP addresses (VIPs...), policies...
LionelJouin added a commit to Nordix/nsm-sdk that referenced this issue Mar 3, 2022
Using the Client chain, the network service client cannot update the
IPContext without the mergeConnectionContext function implemented. A NSC
might want to update it if it needs to add, update or delete routes, src
IP addresses (VIPs...), policies...

Signed-off-by: Lionel Jouin <[email protected]>
LionelJouin added a commit to Nordix/nsm-sdk that referenced this issue Mar 3, 2022
Using the Client chain, the network service client cannot update the
IPContext without the mergeConnectionContext function implemented. A NSC
might want to update it if it needs to add, update or delete routes, src
IP addresses (VIPs...), policies...

Signed-off-by: Lionel Jouin <[email protected]>
LionelJouin added a commit to Nordix/nsm-sdk that referenced this issue Mar 3, 2022
Using the Client chain, the network service client cannot update the
IPContext without the mergeConnectionContext function implemented. A NSC
might want to update it if it needs to add, update or delete routes, src
IP addresses (VIPs...), policies...

Signed-off-by: Lionel Jouin <[email protected]>
@LionelJouin
Copy link
Member Author

Solved: #1238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants