Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes in chain element can cause slow processing of requests #851

Open
NikitaSkrynnik opened this issue Sep 17, 2024 · 2 comments
Open

Closes in chain element can cause slow processing of requests #851

NikitaSkrynnik opened this issue Sep 17, 2024 · 2 comments

Comments

@NikitaSkrynnik
Copy link
Contributor

Main Issue

networkservicemesh/sdk#1666

Description

Many chain elements in sdk-vpp call close in case of failed request: example. Clients can wait for the error from a forwarder for the time much longer than request timeout.
@NikitaSkrynnik NikitaSkrynnik mentioned this issue Sep 17, 2024
Open
@NikitaSkrynnik NikitaSkrynnik self-assigned this Sep 17, 2024
@denis-tingaikin
Copy link
Member

@NikitaSkrynnik Could you please add more details or a diagram to make things more clear?

@NikitaSkrynnik
Copy link
Contributor Author

NikitaSkrynnik commented Nov 6, 2024 •
edited
Loading

Sure. Here is the picture:
Screenshot 2024-11-06 at 15 37 55

If request time takes almost all REQUEST_TIMEOUT and fails somewhere in the middle of the chain, we spend some time to call close. In total, we can exceed REQUEST_TIMEOUT value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Release v1.14.1
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@denis-tingaikin @NikitaSkrynnik