You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lack of or incomplete support of certain features (nullable typed class constants in my case) makes it tempting to extend the base Printer class and introduce my own implementation, but it's very hard due to massive internal dependencies on private methods.
Declaring PsrPrinter class as final also makes it a deadend in terms of extensibility.
Simply changing private methods to protected, and removing final from PstPrinter would greatly improve extensibility of the library without compromising... well, anything.
As a sidenote, support for nullable typed class constants would be a welcome addition.
The text was updated successfully, but these errors were encountered:
Lack of or incomplete support of certain features (nullable typed class constants in my case) makes it tempting to extend the base Printer class and introduce my own implementation, but it's very hard due to massive internal dependencies on private methods.
Declaring PsrPrinter class as final also makes it a deadend in terms of extensibility.
Simply changing private methods to protected, and removing final from PstPrinter would greatly improve extensibility of the library without compromising... well, anything.
As a sidenote, support for nullable typed class constants would be a welcome addition.
The text was updated successfully, but these errors were encountered: