Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think a lot of private members should be declared protected #169

Open
etranger opened this issue Oct 25, 2024 · 1 comment
Open

I think a lot of private members should be declared protected #169

etranger opened this issue Oct 25, 2024 · 1 comment

Comments

@etranger
Copy link

Lack of or incomplete support of certain features (nullable typed class constants in my case) makes it tempting to extend the base Printer class and introduce my own implementation, but it's very hard due to massive internal dependencies on private methods.

Declaring PsrPrinter class as final also makes it a deadend in terms of extensibility.

Simply changing private methods to protected, and removing final from PstPrinter would greatly improve extensibility of the library without compromising... well, anything.

As a sidenote, support for nullable typed class constants would be a welcome addition.

@dg
Copy link
Member

dg commented Nov 1, 2024

fixed, constant type can be nullable 03acaa6 and PsrPrinter is not final c511194

I need to consider protected methods carefully; they can complicate further development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@dg @etranger and others