Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is being signed out after page reload #530

Open
2 of 17 tasks
ozmar-11 opened this issue Aug 2, 2020 · 0 comments · May be fixed by #529
Open
2 of 17 tasks

User is being signed out after page reload #530

ozmar-11 opened this issue Aug 2, 2020 · 0 comments · May be fixed by #529

Comments

@ozmar-11
Copy link
Contributor

ozmar-11 commented Aug 2, 2020

I'm submitting a...

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report
  • Performance issue
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Current behavior

When using OAuth in the same window the authData is not being saved in local storage, just in memory which leads the user to be signed out when the page is reloaded, this issue doesn't happen when using OAuth in new window mode

Expected behavior

The authData should be persisted in local storage, doesn't matter the way he signs in

What is the motivation / use case for changing the behavior?

The users can be tempted to reload the page for any reason, and their session should be persisted so they are nor signed out if their session is still valid

Environment

Angular-Token version: 7.0.1
Angular version: 9.1.9

Bundler

  • Angular CLI (Webpack)
  • Webpack
  • SystemJS

Browser:

  • Chrome (desktop) version XX
  • Chrome (Android) version XX
  • Chrome (iOS) version XX
  • Firefox version XX
  • Safari (desktop) version XX
  • Safari (iOS) version XX
  • IE version XX
  • Edge version XX

Others:

@ozmar-11 ozmar-11 linked a pull request Aug 2, 2020 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant