Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Partial publish only the deletion of a Node but node descendant Node moves #5364

Open
mhsdesign opened this issue Nov 13, 2024 · 0 comments

Comments

@mhsdesign
Copy link
Member

Steps to reproduce:

  1. Cut a content element on Page A in a nested content collection like a slider: (main/slider)
  2. Paste (which is move) the content element to Page B (main/slider)
  3. Delete the content collection slider on Page A (main/slider)
  4. Publish individually on PageA the removal

Expected:

The removal is either published and the moved node preserved in the remaining changes
or the editor is explained to that this is not possible.

Actual:

Beta15
As the step 2 cannot be applied on the users workspace as remaining events because the Node was indirectly deleted first due to the attempted publish of the removal 3. The conflict resolution will show up - thinking its a synchronisation problem with live - and tell that the move is not applicable and propose to drop it. But because a Rebase(force) is issued, which does nothing in this case as we are up to date nothing is dropped and the dialog will show up again.

Beta13
There is a chances it behaves differently from Beta15 and the move node WAS possible afterwards as the deletion of nodes was not correct until: #5320

So similarly to #5352 we would have events in the wrong order stating to now move a node while it was deleted first.

Ideas to fix

Improve the conflict resolution so in case the workspace is up to date AND the remaining events were not applicable tell the user that the change cannot be published as is but needs the move node as well.

mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this issue Nov 13, 2024
reparation for upgrading to beta 15

see also neos#5364
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this issue Nov 14, 2024
we would have to delete too many events that were legit as well, like a move AFTER a deletion neos#5364
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this issue Nov 15, 2024
neos-bot pushed a commit to neos/contentrepositoryregistry that referenced this issue Nov 18, 2024
neos-bot pushed a commit to neos/contentrepositoryregistry that referenced this issue Nov 18, 2024
we would have to delete too many events that were legit as well, like a move AFTER a deletion neos/neos-development-collection#5364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant