-
-
Notifications
You must be signed in to change notification settings - Fork 222
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
TASK: Docs and readability of Node::getProperty
When seeing code like ``` $this->properties[$propertyName] ``` i always assume it will throw if the key not exits. In our case the property collection will just return null instead. To make this more obvious A: i like to add a nullish-coalescing or B: use offsetGet similar to hasProperty uses offsetExist Also the doc comment was adjusted, as its actually the same from the old cr and we dont have those funny content object dingsis anymore
- Loading branch information
Showing
2 changed files
with
8 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters