-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Adjust to PHP 8.3 get_parent_class() deprecation #3406
base: 8.3
Are you sure you want to change the base?
BUGFIX: Adjust to PHP 8.3 get_parent_class() deprecation #3406
Conversation
Thank you! :) Good catch |
Please do not merge this. For reasons still unknown to me, this leads to the following exception when querying repositories that extend other repositories: Call to a member function createQueryForType() on null
Type: Error
File: Packages/Framework/Neos.Flow/Classes/Persistence/Repository.php
Line: 137 So somehow this leads to the |
See further comments in #3351 |
hmmm thanks for your pr ... but that error would be odd to be caused by this change? I myself am using php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did exactly this change in a project yesterday… great to see there's a PR already. 🤣
I, too, doubt that this causes the regression, see also #3351 (comment) |
Somehow, https://github.com/neos/flow-development-collection/pull/3351/files only targeted Flow 9.0, but per the docs, Flow 8.3 also supports PHP 8.3.
This is just a backport of these changes.