Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Deprecate ControllerContext::getFlashMessageContainer #3292

Draft
wants to merge 2 commits into
base: temporary-mvc-refactoring-target-branch
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

Upgrade instructions

As AbstractController::addFlashMessage should be used to add FlashMessages rather than interacting with the container directly this deprecation should go unnoticed.
If its required, one should use the FlashMessageService to get the container:

$this->flashMessageService->getFlashMessageContainerForRequest($this->request)
    ->addMessage($errorFlashMessage);

Review instructions

This pr should not be merged before targeting 9.0.
See #3232 (comment) for explanation.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign force-pushed the task/deprecateControllerContextGetFlashMessageContainer branch from 26e12bd to e564aa6 Compare February 3, 2024 14:51
@mhsdesign mhsdesign force-pushed the temporary-mvc-refactoring-target-branch branch 2 times, most recently from 080c854 to f37ce2c Compare March 3, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant