Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!!! FEATURE: ViewInterface returns PSR StreamInterface #3286

Merged
merged 10 commits into from
Apr 24, 2024
Merged

!!! FEATURE: ViewInterface returns PSR StreamInterface #3286

merged 10 commits into from
Apr 24, 2024

Commits on Apr 22, 2024

  1. WIP: Make ViewInterface independent of controller context

    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    93ba58d View commit details
    Browse the repository at this point in the history

  2. WIP: Introduce ActionMessages tuple to replace controller context

    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3afca62 View commit details
    Browse the repository at this point in the history

  3. Revert "WIP: Introduce ActionMessages tuple to replace controller con… 

    …text"

This reverts commit 2717a8c.
    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ac8cfc7 View commit details
    Browse the repository at this point in the history

  4. !!! TASK JsonView returns ResponseInterface directly

    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d91c6a2 View commit details
    Browse the repository at this point in the history

  5. Fix ci

    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    227670a View commit details
    Browse the repository at this point in the history

  6. !!! TASK: ViewInterface::canRender 

    Initially `canRender` was introduced to allow special logic in a controller to determine the correct view out of multiple options.
neos@cb8fa24

But with neos@d69bcfe the canRender() checks were removed and leaves the method with zero usages and no _real_ implementation.
    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1ae08a8 View commit details
    Browse the repository at this point in the history

  7. !!! TASK: Strict render type for views `ResponseInterface|StreamInter… 

    …face`

Please adjust your view to return a `StreamInterface` instead of a stream.
If you need a string at call site, please use `->getContent()` instead.
    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cc8f3a9 View commit details
    Browse the repository at this point in the history

  8. TASK: Refactor stream sending

    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9bb5133 View commit details
    Browse the repository at this point in the history

  9. TASK: Update composer.json build

    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ff51048 View commit details
    Browse the repository at this point in the history

  10. !!! TASK: Add strict types to ViewInterface

    @mhsdesign
    mhsdesign committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    524f61e View commit details
    Browse the repository at this point in the history