-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardfork HF_Echidna #3454
base: master
Are you sure you want to change the base?
Add hardfork HF_Echidna #3454
Conversation
src/Neo.CLI/config.fs.mainnet.json
Outdated
@@ -40,7 +40,8 @@ | |||
"HF_Aspidochelone": 3000000, | |||
"HF_Basilisk": 4500000, | |||
"HF_Cockatrice": 5800000, | |||
"HF_Domovoi": 5800000 | |||
"HF_Domovoi": 5800000, | |||
"HF_Echidna": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to plan when we're going to have the next release. May be we can postpone configuration changes until some real proximity to the release and in this PR add only HF_Echidna
enum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to plan when we're going to have the next release. May be we can postpone configuration changes until some real proximity to the release and in this PR add only
HF_Echidna
enum?
Its placeholder, can be updated before merge to the master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make configs stored in the master
branch unusable for real synchronization for some time, nothing good about that. Better omit it, declare HF_Echidna
(we need it and will use it), but update configs later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make configs stored in the
master
branch unusable for real synchronization for some time, nothing good about that. Better omit it, declareHF_Echidna
(we need it and will use it), but update configs later.
this will not be merged to the master branch until we decides to release new version.
* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count
* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.
* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count
* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count
* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.
# Conflicts: # src/Neo/Neo.csproj # src/Neo/SmartContract/Native/RoleManagement.cs
16a9c29
to
0457ccd
Compare
Description
Designation
event #3397Fix
]: integer overflow inJumpTable.SubStr
#3496