Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEAR/My NEAR wallet to use local private key to verify owner #522

Closed
tituszban opened this issue Oct 23, 2022 · 2 comments
Closed

NEAR/My NEAR wallet to use local private key to verify owner #522

tituszban opened this issue Oct 23, 2022 · 2 comments
Labels
change-request A request to change an existing component or feature

Comments

@tituszban
Copy link

Description

The NEAR web wallet stores the function access private keys it used to sign in, in local storage. Instead of having to go to a redirect, it would be much better, if it just used those, to sign the requested message.

If applicable add: Relates to #318

Acceptance Criteria

Update the NEAR and My NEAR (and other web wallets where applicable) to use the local storage keys to sign a message.

Alternatively, allow verifyOwner to specify if a function access or full access key should sign the message, and only redirect to the wallet if full access keys were requested.

@tituszban tituszban added the change-request A request to change an existing component or feature label Oct 23, 2022
@AmmarHumackicSQA
Copy link
Contributor

AmmarHumackicSQA commented Oct 26, 2022

Hey @tituszban , thanks for raising this issue! We will take a look at this, as we are already investigating the reuse of the LAK (limited access key) stored in local storage.

Regarding verifyOwner (and the #318 you mentioned), there is a NEP in the works that should be raised soon. You can check the draft of it here: near/NEPs#413

@near near deleted a comment from exalate-issue-sync bot Oct 26, 2022
@amirsaran3
Copy link
Collaborator

@tituszban The current implementation of verifyOwner in wallet-selector is not right. verifyOwner should be used before signing in without a wallet. We are working on a standard and implementation for this.

NEP: near/NEPs#413

If you have other questions feel free to reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-request A request to change an existing component or feature
Projects
None yet
Development

No branches or pull requests

3 participants