-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank space scrolling up in stackblitz? and vue/angular codesandbox from website errors out? #535
Comments
thanks. Test with version 4.10.0-beta.1. https://codesandbox.io/s/ngx-infinitegrid-4-10-0-osjimx?file=/src/app/app.component.ts |
so i am not sure if the change 4.10.0 is working in other cases but it seems that the blank space does not appear when scrolling up after scrolling down with the 4.10.0-beta.1 for this specific codesandbox: but what changed or the cause of the issue? |
4.10.0 is released. Test it again. |
I wasn't able to make the demo codesandbox from https://naver.github.io/egjs-infinitegrid/storybook to work but I think I was able to get it to work after creating an angular codesandbox project from scratch. a few things that I thought I should share when trying to make 4.10.0 to work in codesandbox/stackblitz:
And another thing, I noticed that the docs |
So, I am not sure what happened but after checking the 4.10.0 release info and that there was an update to angular 15, I thought maybe the cause of the previously mentioned error of codesandbox not running was due to version difference?
So I created a stackblitz with angular 15 with 4.10.0 and, unlike the previous message stackblitz link, it seemed to not error out but instead some blank spaces after scrolling issue, scroll limit, and ordering seemed to change again. Though it is inconsistent and I cannot consistently reproduce the behavior. This inconsistent behavior was something I noticed only in stackblitz. The issue opening codesandbox from https://naver.github.io/egjs-infinitegrid/storybook/?path=/story/examples-masonryinfinitegrid--masonry-infinite-grid-template erroring out is still an issue I am encountering. Not sure if others are experiencing this so I didn't raise another separate issue. |
Description
Hello,
I came across this library and thought it was really cool and wanted to play around with it in my angular 15 project.
I tried to first use NgxMasonryInfiniteGrid with one column with the main goal of seeing if it is possible to use this library to use as virtual list/scroll with dynamic height items.
So I attempted to mimic virtual list with dynamic height in the first codesandbox link and so far so good as it seems that the items are virtualized but scrolling back up show blank space.
I am not sure if this is only on my end and it seemed like it was related to #91 but was already closed.
Steps to check or reproduce
forked from storybook demo with the dummy dynamic height attempt:
https://codesandbox.io/s/fragrant-forest-h4fnhz?file=%2Fsrc%2Fapp%2Fapp.component.html
forked from storybook demo with column set to 1 to double check if my additional code was the cause but still shows blank space scrolling up:
https://codesandbox.io/s/vigilant-currying-k9eicz?file=%2Fsrc%2Fapp%2Fapp.component.html
The text was updated successfully, but these errors were encountered: