Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize ROS2 Migration #346

Open
1 of 3 tasks
Cakem1x opened this issue Oct 16, 2024 · 2 comments
Open
1 of 3 tasks

Finalize ROS2 Migration #346

Cakem1x opened this issue Oct 16, 2024 · 2 comments
Assignees

Comments

@Cakem1x
Copy link
Member

Cakem1x commented Oct 16, 2024

The humble branch currently tracks the latest move base flex version for ROS2.

I want to tackle the following post migration ToDos:

  • update default branch: from master to humble
  • branch protection rule for humble
  • update readmes (ROS2 readme (humble), ROS1 readme (master))
    • add logos for companies
    • add/update notice about and link to ROS1 and ROS2 branch
    • add news/announcements section, include info about which parts are migrated and which are not.
@Cakem1x
Copy link
Member Author

Cakem1x commented Oct 16, 2024

Before changing the default branch to humble, I'd like to get confirmation from other maintainers on whether that will break anything critical (@spuetz @corot ).
The rationale for this change is that it makes the landing of new people on the repo's main page nicer, assuming most of them are interested in using ROS2.

@corot
Copy link
Collaborator

corot commented Oct 18, 2024

Before changing the default branch to humble, I'd like to get confirmation from other maintainers on whether that will break anything critical (@spuetz @corot ). The rationale for this change is that it makes the landing of new people on the repo's main page nicer, assuming most of them are interested in using ROS2.

I think the default branch should always be master. But if most new developments will be on ROS 2, it makes sense to

  • rename master as noetic
  • rename humble as master
    But as migration is still wip (costmap server missing), we need to wait to do that

Besides that, I think there are changes in jazzy that break compatibility with costmaps, so future master should work for jazzy, not humble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants