Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding Errors on Initialization #331

Open
AlexanderDavid opened this issue Nov 14, 2023 · 0 comments
Open

Hiding Errors on Initialization #331

AlexanderDavid opened this issue Nov 14, 2023 · 0 comments

Comments

@AlexanderDavid
Copy link

https://github.com/magazino/move_base_flex/blob/c02460e9bc1dbfb2e82348b308cc3fa1e3d12cda/mbf_abstract_nav/include/mbf_abstract_nav/impl/abstract_plugin_manager.tcc#L106

This try catch block will catch any XMLRPC value errors and incorrectly attribute them to the controller parameter structure. It would probably be better to just say there was an XMLRPC error when loading the plugin and let the user figure out the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant