Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrickOps: Update send_hs.py to match latest send_hs output Trick produces #1807

Open
ddj116 opened this issue Nov 20, 2024 · 0 comments
Open
Assignees

Comments

@ddj116
Copy link
Contributor

ddj116 commented Nov 20, 2024

Background

In the time since utility python module share/trick/trickops/send_hs.py was added to TrickOps (3/2023), Trick has moved on to a different output in the send_hs file that gets created, so this utility module is currently broken in the latest state of master. When I originally added send_hs.py it was not added with unit testing, so it's break was never discovered by Trick's CI.

What this issue will address

In this issue I will update send_hs.py to work with the latest output and add a unit test to cover it's usage, something I should have done in the first place!

What we use it for

For the curious, we use this module to help us get send_hs data into a format we can more easily plot in our CI system. For example, here's one such plot showing us how our realtime performance ratio changes over time, where the x-axis is CI job number. It's a nice way for us to see if anything comes into our production branches that significantly affect realtime performance.

Screenshot 2024-11-20 at 3 23 07 PM

Each colored line represents one of our Orion scenarios we continually test in CI. Happy to provide more details on the plot if anyone in the community is interested in the details.

FYI @sharmeye @jmpenn @hchen99 for awareness

@ddj116 ddj116 self-assigned this Nov 20, 2024
ddj116 pushed a commit that referenced this issue Nov 21, 2024
* Update pip when testing trickops
* Remove MonteCarloGenerationhelper.py's
* unecessary dependency on send_hs
* Update send_hs.py to work with the new fields Trick's output produces.

TODO: unit tests

Closes #1807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant