Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for customizable timeout #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zlender
Copy link

@Zlender Zlender commented Mar 2, 2022

This allows for customizable timeout in either command line or library mode.

The issue was first raised in #10 and I think this fixes it.

@Zlender
Copy link
Author

Zlender commented Mar 2, 2022

Test script I used

from ssl_checker import SSLChecker
SSLChecker = SSLChecker()
args = {
  'timeout' : 2.0,
  'hosts' : [
    'acquiacustomertest.com',
    'ks-1.sandbox.acquia.io',
    'master.e.as5001dualar.ahserversdev.com',
]}
response = SSLChecker.show_result(SSLChecker.get_args(json_args=args))
time python3.9 test.py
python3.9 test.py  0.06s user 0.02s system 3% cpu 2.520 total```

Without the timeout

from ssl_checker import SSLChecker
SSLChecker = SSLChecker()
args = {
  'hosts' : [
    'acquiacustomertest.com',
    'ks-1.sandbox.acquia.io',
    'master.e.as5001dualar.ahserversdev.com',
]}
response = SSLChecker.show_result(SSLChecker.get_args(json_args=args))
time python3.9 test.py
python3.9 test.py  0.06s user 0.04s system 0% cpu 1:15.61 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant