-
|
Hey 👋 Just want to clarify how Even outside of GoNix itself I observe the following behaviour: (⎈ |local:default)
prologic@Jamess-iMac
Thu Sep 15 13:57:08
~/tmp/sh
(master) 0
$ ./gosh
$ ^C
(⎈ |local:default)
prologic@Jamess-iMac
Thu Sep 15 13:57:11
~/tmp/sh
(master) 130
$ echo $?
130
In say a Bash shell, Some context, to this question. I'm actually trying to debug some missing or bad signal handling where-by hitting Thoughts? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 7 replies
-
|
I assume this is a question for cmd/gosh, the main program that implements a fairly basic interactive shell? There's a fairly easy answer here: we don't set up any signal handlers, so ^C has its default behavior, which is to kill the entire process :) We should probably teach gosh to do the right thing instead, which seems to be to discard the in-progress line and start a new line. |
Beta Was this translation helpful? Give feedback.
-
|
Agreed 👌 |
Beta Was this translation helpful? Give feedback.
-
|
Happy to review a PR :) I think we can do without a test for now, because it's slightly tricky to test (we would need a separate process), and we currently only test runInteractive. But of course also happy to review an end-to-end test. If you don't have time for a PR then that's also fine - then we should move this to the issue tracker. |
Beta Was this translation helpful? Give feedback.
-
|
@mvdan Would you accept a patch like the one here: https://git.mills.io/prologic/gonix/commit/d8755bba8d09259551280134399faa40ad8e7e9a if so I'll submit a PR as I've basically just borrowed most of your |
Beta Was this translation helpful? Give feedback.
-
|
Yep, something like that looks right! And yup, cmd/gosh is of course open source, but it's not really meant to be a fully featured shell. If someone wanted to contribute such a fancy shell (with readline, autocompletion, etc) that could always be an option, though it would likely have to be a separate Go module to not add unnecessary dependencies to the main module. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah right now that's pretty much all I'm missing from a traditional POSIX(ish) shell:
What else do you want? 🤔 |
Beta Was this translation helpful? Give feedback.
-
|
I don't mind spinning this into a separate project, but it will have a |
Beta Was this translation helpful? Give feedback.
-
|
That list sounds right. I think the main tricky part is the API, because some users may want a significant amount of control over certain features like autocompletion or history. |
Beta Was this translation helpful? Give feedback.
-
|
FWIW I tried to integrate the elvish shell into my project, but it turns out it wants to have a database and a daemon just to store history 😳 It also turns out that this is rather controversial 🤔 So I've switched back to your project, added the appropriate signal handling and I'm quite happy so far 👌 As the need arises I might spawn a new |
Beta Was this translation helpful? Give feedback.
I assume this is a question for cmd/gosh, the main program that implements a fairly basic interactive shell?
There's a fairly easy answer here: we don't set up any signal handlers, so ^C has its default behavior, which is to kill the entire process :) We should probably teach gosh to do the right thing instead, which seems to be to discard the in-progress line and start a new line.