Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behaviour of test-lyrics #150

Open
annplaksin opened this issue Jun 2, 2020 · 0 comments
Open

Strange behaviour of test-lyrics #150

annplaksin opened this issue Jun 2, 2020 · 0 comments

Comments

@annplaksin
Copy link
Member

To test pr #149 I deleted the @wordpos from that element in lyrics.mei: re,`
And the test results where:

 1) Lyrics
       wordpos
         marks terminal syllables (@wordpos='t'):
     AssertionError [ERR_ASSERTION]: value for wordpos not found on element index 3 (syl) ("<syl xmlns="http://www.music-encoding.org/ns/mei" xml:id="m-50">re,</syl>")
      at Object.assertAttrOnElements (test\mocha\utils.js:21:16)
      at Context.it (test\mocha\test-lyrics.js:35:13)

  2) Lyrics
       wordpos
         handles single syllable words (omit @wordpos):
      AssertionError [ERR_ASSERTION]: value for wordpos unexpectedly found on element index 3 (syl) ("<syl xmlns="http://www.music-encoding.org/ns/mei" xml:id="m-50">re,</syl>")
      + expected - actual
      at Object.assertAttrOnElements (test\mocha\utils.js:23:16)
      at Context.it (test\mocha\test-lyrics.js:38:13)

Number 1 is totally obvious, I provoked that... but I don't understand why number 2 is showing up. It's kind of contradictory.
The arrays of indices seem fine to me... and when I put the attribute back, again all tests are running without errors.

As long as the tests don't fail to detect errors, it's not a huge problem, but it might be worth to look into this at some time in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant