WIP: FIX(client): Fix Windows unicode paths on writing files with ofstream #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hartmnt
force-pushed
the
fix_unicode_path
branch
3 times, most recently
from
ae295fd
to
a63ba6c
Compare
Krzmbrzl
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Has this already been tested on an actual Windows machine that could reproduce the original issue?
Changes LGTM. However, I think the commit message should contain a short explanation as to why this change was necessary in the first place. That'll make future change reasoning easier :)
Krzmbrzl
added
client
windows
bug
Yes, this is very much not complete, yet. It does not compile on Windows. However, the Windows CI pipeline is currently broken (see translation PR for example) When this is fixed, i'd like to give the CI build to the bug reporters to test |
Hartmnt
force-pushed
the
fix_unicode_path
branch
10 times, most recently
from
5dc0e5b
to
aaaa5c2
Compare
Hartmnt
force-pushed
the
fix_unicode_path
branch
from
aaaa5c2
to
e36562f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.