Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding CI #3

Closed
wants to merge 12 commits into from
Closed

[WIP] Adding CI #3

wants to merge 12 commits into from

Conversation

junaruga
Copy link
Member

@junaruga junaruga commented Jun 8, 2019

DO NOT merge this PR yet.
This is working PR for #2 .

Current CI result:
https://travis-ci.org/multiarch/busybox/builds/543095257

To align the indent with other multiarch/* update.sh.
Replace 2nd curl with wget.
Because curl does not return an error exit status, when the URL is not found
HTTP 404. Also print the HTTP error message.
Outdated deb files pointing out outdate URLs cause a error.
To avoid "ln -s" command file existing error
This does not happen a local bash 5.

++./bin/busybox --list-modules
./update.sh: line 51: ./bin/busybox: No such file or directory
Signed-off-by: Jun Aruga <[email protected]>
Signed-off-by: Jun Aruga <[email protected]>
ls -l $(pwd)/bin
ls -l $(pwd)/bin/busybox
$(pwd)/bin/busybox --help
$(pwd)/bin/busybox --list-modules
Copy link
Member Author

@junaruga junaruga Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an interesting error here. $(pwd)/bin/busybox --help is not recognized

https://travis-ci.org/multiarch/busybox/builds/543095257

++pwd
+ls -l /home/travis/build/multiarch/busybox/alpha/slim/rootfs/bin/busybox
-rwxr-xr-x 1 travis travis 2382376 Apr  1 05:17 /home/travis/build/multiarch/busybox/alpha/slim/rootfs/bin/busybox
++pwd
+/home/travis/build/multiarch/busybox/alpha/slim/rootfs/bin/busybox --help
./update.sh: line 51: /home/travis/build/multiarch/busybox/alpha/slim/rootfs/bin/busybox: No such file or directory

This issue only happens on Travis CI environment.
This is okay on my local environment (Fedora 30).

@lafin
Copy link

lafin commented Jun 12, 2019

To prevent accidental merging, you can use the Draft mode for PR.
https://github.blog/2019-02-14-introducing-draft-pull-requests/

@junaruga
Copy link
Member Author

junaruga commented Jun 12, 2019

@lafin thank you for the information. Next time I will take care of using the draft mode, to prevent it to be merged wrongly. It seems that once we created the pull-request, can not change it to draft pull-request mode.

I am sorry I did not mention why I shared this working in progress pull-request (WIP).
Because I wanted to share the above issue "bin/busybox: No such file or directory" that I could not solve at that time. I expected if I shared publicly, I might get some advises.

@junaruga junaruga closed this Jun 12, 2019
@junaruga
Copy link
Member Author

I would close this ticket to prevent it will be merged.
When I needed in the future, I will open new PR with draft mode if it is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants