Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] GitHub Action to lint PR titles #239

Open
3 tasks
oliviertassinari opened this issue Nov 7, 2024 · 0 comments
Open
3 tasks

[infra] GitHub Action to lint PR titles #239

oliviertassinari opened this issue Nov 7, 2024 · 0 comments
Labels
dx Related to developers' experience new feature New feature or request scope: infra Org infrastructure work going on behind the scenes status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 7, 2024

Summary

Too often I see problems with the commit messages go into the main branch and hence in the changelog:

  • Extra dots. No, there shouldn't be a .. Example: mui/mui-x@a62b88f
  • [main tag] format done wrong. Example: mui/mui-x@565de78
  • Apply Vale config to the title to make sure it fits with our rules, e.g. Webpack -> webpack

See the overall policy: https://www.notion.so/mui-org/GitHub-PRs-7112d03a6c4346168090b29a970c0154?pvs=4#258c9e963dc445348562a52a62052941

We could have a logic that, like https://github.com/mui/mui-public/blob/master/.github/workflows/check-if-pr-has-label.yml would ensure that there is no dot.

Examples

Kind of the opposite of mui/material-ui#44292.

Motivation

No response

Search keywords: -

@oliviertassinari oliviertassinari added new feature New feature or request status: waiting for maintainer These issues haven't been looked at yet by a maintainer scope: infra Org infrastructure work going on behind the scenes dx Related to developers' experience labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Related to developers' experience new feature New feature or request scope: infra Org infrastructure work going on behind the scenes status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant